Posts: 3
Threads: 1
Joined: Nov 2019
11-05-2019, 09:19 AM
(This post was last modified: 11-05-2019, 09:19 AM by maabed.)
Hi,
I encountered what I think to be a bug in the way that the [Build Shape Extrusion] Module should behave with [Build Volume Caps]. It happens when using a custom Animation Curve for the scale of the [Build Shape Extrusion] Module, the problem is that the module doesn't account for the Animation Curve scale value when using with the Volume Caps. And it's the case only for the last cap and not the first one.
Please refer to the following image to get a better understanding of what I mean : https://pasteboard.co/IFg17vz.png
I hope this could be a simple fix or a workaround since the logic for accounting for the scale is already there, I believe the scaling should be done in regards to each cap.
Kind regards,
maabed
Posts: 2,114
Threads: 92
Joined: Jun 2017
Hi,
Thanks for the bug report. From first look, it shouldn't be difficult to fix. Will update this thread once it is done.
Have a nice day
Please consider leaving a
review for Curvy, this helps immensely. Thank you.
Available for freelance work—feel free to reach out.
Posts: 3
Threads: 1
Joined: Nov 2019
(11-05-2019, 05:45 PM)_Aka_ Wrote: Hi,
Thanks for the bug report. From first look, it shouldn't be difficult to fix. Will update this thread once it is done.
Have a nice day
Hi,
Thank you very much for your reply. I'm very eager to hear from you
I tried to go through the source myself, however, I couldn't find the logic that relates the Volume Caps scale to the custom animation curve.
Have a great evening,
Maabed
Posts: 3
Threads: 1
Joined: Nov 2019
Hi Again,
After digging through the source code once more (which is an excellent code base by the way and it makes you feel that it was written by very smart people) I was able to figure it out. The issue is related to the LibTessDotNet library, more specifically it happens when creating the contour for the end cap. Since the segment index was set to 0, the vertices get welded with the first cap vertices causing the scaling to be dependent on the first cap. Whereas the contour should be created for last segment index.
Also, I think the same kind of behaviour will happen when creating volume holes for the caps (Just a guess, I haven't tested it out yet).
Here's a screenshot that demonstrates the fix: https://pasteboard.co/IFkHkgA.png
And here's the expected result: https://pasteboard.co/IFkIRbO.png
Hope this would be helpful for someone else
Best,
Maabed
Posts: 2,114
Threads: 92
Joined: Jun 2017
(11-05-2019, 09:18 PM)maabed Wrote: which is an excellent code base by the way and it makes you feel that it was written by very smart people
Thank you. Most of the code was written by
Jake, the asset creator who does not work anymore on the asset.
Please consider leaving a
review for Curvy, this helps immensely. Thank you.
Available for freelance work—feel free to reach out.
Posts: 2,114
Threads: 92
Joined: Jun 2017
And thank you for sharing the fix. It will be included in the next update.
Please consider leaving a
review for Curvy, this helps immensely. Thank you.
Available for freelance work—feel free to reach out.