CurvySpline.GetExtrusionPoint() does not account for orientation

[chris]

So in my testing, CurvySpline.GetExtrusionPoint() does not appear to account for orientation. Which means I need to calculate a rotation anyway which makes the method basically pointless as I can just use my rotation to extrude a point directly myself anyway.

I couldn't find any actual uses of GetExtrusionPoint in the codebase, is this the intended functionality of this method?

[Jake]

So in my testing, CurvySpline.GetExtrusionPoint() does not appear to account for orientation. Which means I need to calculate a rotation anyway which makes the method basically pointless as I can just use my rotation to extrude a point directly myself anyway.

Hi Chris,

right, you'll need to feed in orientation by yourself, but you don't need to calculate it:

Code:

Vector3 pos=Spline.Interpolate(0.5f);
Vector3 tangent=Spline.GetTangent(0.5f);
Vector3 up=Spline.GetOrientationUpFast(0.5f);
Vector3 targetPoint=GetExtrusionPoint(pos,tangent,up,4f,180f); // gives a point on the opposite of the splines Up-Vector (180°) at 4 units distance

In fact GetExtrusionPoint is just a shortcut for a few calculations, useful for those who don't know how to calculate it. I could have reduced it to just radius and angle, but than I would have to had 2 methods (+one that uses the Fast() methods). I thought that this isn't really neccessary as this isn't a widely used method.

Jake

[chris]

Fair enough.

I'd recommend making it a static method if it doesn't actually leverage any of the member data that it has available to it from the current spline. That would help identify it as a helper method better as well.

[Jake]

Fair enough.

I'd recommend making it a static method if it doesn't actually leverage any of the member data that it has available to it from the current spline. That would help identify it as a helper method better as well.

Good idea, I'll do that.

[chris]

Thanks for the new GetExtrusionPoint method btw. This one is much more convenient to work with.