Rasterized Path Range issue

[proton]

Hi, I want to deform a spring mesh along a spline, and animate Rasterized Path's From/To property to create a stretch animation, but the Curvy Generator always throws ArgumentNullException. After some investigation, I found when set To=1, it's actual value becomes 0, and From is also 0，so the CGPath is null. In the BuildRasterizedPath.cs， I see From/To property make some clamp for value:

Code:

public float From
{
    get => m_Range.From;
    set
    {
        float v = DTMath.Repeat(
            value,
            1
        );
        if (m_Range.From != v)
        {
            m_Range.From = v;
            Dirty = true;
        }
    }
}

public float To
{
    get => m_Range.To;
    set
    {
        float v = Mathf.Max(
            From,
            value
        );
        if (ClampPath)
            v = Mathf.Repeat(
                value,
                1
            );
        if (m_Range.To != v)
        {
            m_Range.To = v;
            Dirty = true;
        }
    }
}

From use a specific DTMath.Repeat to clamp the value, which keep 1 for 1, but To still use Mathf.Repeat, which make 1 becomes 0. After replace Mathf.Repeat with  DTMath.Repeat, it can work normally. So should it be DTMath.Repeat too for To property?

In addition, when set From and To with same value, which means Length = 0, the Generator always throws ArgumentNullException, I guess when the Length = 0,  CGPath always is null. Can it generate a empty path/mesh, otherwise I have to keep a small distance between From and To to avoid the ArgumentNullException.

Beside, To use Mathf.Max(From, value) to make sure it >= From, but the From don't have such check. So when set the range, To must set after From. Should From also do the same?

Thanks.

[_Aka_]

Hi
Your points seem valid, I will look into this and update you shortly.
Have a nice day

[_Aka_]

Here are my findings regarding the issues you raised. Please correct me if I forgot something:

1. Invalid From and To setters: You are right. Please replace these implementations with the ones from BuildShapeExtrusion. These don't have the issue.
   
2. ArgumentNullExceptions when path has 0 length: I could not reproduce this issue. Can you please send me a reproduction case?
   
3. the check for From <= To: You are right, the results differ depending on whether you set From first or To first. This is something I will work on in the future. For now, make sure your set To after From.
   

I hope this helped.
If and when you feel like it, please leave a review for the asset, that helps a lot.
Have a nice day

[proton]

Hi Here is how to reproduce this issue. The generator graph is created from Deform Template. You can see then set From and To in Rasterized path to same value, it will throw ArgumentNullException. This issue still exists after I update to the latest version.

Thanks.

[_Aka_]

Will try to reproduce it soon. Will keep you updated.

[_Aka_]

Hi,

Here is the fix:
In DeformMesh.cs, go to line 128. It should read like this:

Code:

if (inputMeshes.Count != 0)

Replace it with

Code:

if (path != null && inputMeshes.Count != 0)

This should fix the issue.

I hope this helped.
If and when you feel like it, please leave a review for the asset, that helps a lot.
Have a nice day

[proton]

Ok, that works. I should have reviewed the asset long ago. Many thanks.

[_Aka_]

Thank you for everything, and sorry about the issue in the first place.